Cookies with samesite=none must have the secure attr set #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Jan 4, 2022
| @@ -22,5 +22,17 @@ export const set = (res: ServerResponse, name: string, value: string, options: C | |||
| }; | |||
|
|
|||
| export const clear = (res: ServerResponse, name: string, options: CookieSerializeOptions = {}): void => { | |||
| set(res, name, '', { ...options, maxAge: 0 }); | |||
| const { domain, path, secure, sameSite } = options; | |||
There was a problem hiding this comment.
sameSite is not being passed to set, because it's never added to clearOptions.
There was a problem hiding this comment.
Ooops didn't see you had already closed the PR.
There was a problem hiding this comment.
That's intentional - you only need to pass path and domain (and sometime secure) when clearing the cookie, I'm just closing this because I can't reproduce #569 on https://localhost and I'm doing a bit more investigation
|
Update: reproduced #569 in an iframe and verified the fix in https://codepen.io/adamjmcgrath/pen/bGoKBMW |
Widcket
approved these changes
Jan 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue where transient and session cookies weren't cleared when
SameSite=NoneReferences
fixes #569
Testing
Checklist
main