Enforce configured host on user supplied returnTo #557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes how the user supplied
returnTo
param from/api/auth/login
is sanitized.Instead of using a regexp like a block list to prevent URLs that aren't relative from being accepted, it converts the URL to absolute using the configured
redirect_uri
as a base. It then enforces that the absolute URL has the same origin as the configuredredirect_uri
.This will ensure that only valid URLs with the same origin as the configured
redirect_uri
(orbaseURL
) are accepted asreturnTo
URLs.References
Fixes #545
See also #555
Testing
Tested using https://github.com/adamjmcgrath/open-redirect-finder