Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the ID Token before deleting the session #267

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

adamjmcgrath
Copy link
Contributor

Description

Auth0 logout doesn't use id_token_hint, but we should still make sure it's passed to openid-client#endSessionUrl as the underlying library is idp agnostic.

References

fix #265

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath requested a review from a team as a code owner February 1, 2021 17:07
@vercel
Copy link

vercel bot commented Feb 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/auth0/nextjs-auth0/7n9p3x2w8
✅ Preview: Canceled

@adamjmcgrath adamjmcgrath merged commit 54894c6 into beta Feb 1, 2021
@adamjmcgrath adamjmcgrath deleted the fix-id-token-hint-on-logout branch February 1, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants