Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-2258] Prevent custom session props being removed when refreshing AT #257

Merged
merged 2 commits into from
Jan 26, 2021
Merged

[SDK-2258] Prevent custom session props being removed when refreshing AT #257

merged 2 commits into from
Jan 26, 2021

Conversation

adamjmcgrath
Copy link
Contributor

Description

When a new AT is fetched, the session is also updated with a new ID Token and corresponding claims. Custom claims (usually added in the afterCallback hook) should not be removed when these new claims are applied.

References

fix #161

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath added the review:small Small review label Jan 26, 2021
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner January 26, 2021 11:56
@vercel
Copy link

vercel bot commented Jan 26, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/auth0/nextjs-auth0/ccy3hu590
✅ Preview: Canceled

[Deployment for 980255b canceled]

@Widcket Widcket linked an issue Jan 26, 2021 that may be closed by this pull request
getAccessToken clears custom session.user attributes set via onUserLoaded #161
Closed
@Widcket Widcket merged commit 23545e1 into beta Jan 26, 2021
@Widcket Widcket deleted the persist-custom-user-props branch January 26, 2021 15:48
@Widcket Widcket mentioned this pull request Jan 26, 2021
Closed
@Widcket Widcket mentioned this pull request Feb 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getAccessToken clears custom session.user attributes set via onUserLoaded
2 participants
@adamjmcgrath @Widcket