AggregateError#message from Issuer.discover
includes stack trace
#236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One of the errors thrown by
Issuer.discover
is anAggregateError
, which encapsulates all the errors thrown when theopenid-client
tries to find awell-known
endpoint.The
error.message
of theAggregateError
includes a\n
separated string of a list of the entire errors (String(error)
) - stack trace included (See https://github.com/sindresorhus/aggregate-error/blob/v3.1.0/index.js#L26-L31)In production we don't want to show the stack trace, so the error message in this case needs to be amended. Instead of trying to edit the error message, we're opting for showing the first error in the aggregate, on the assumption that, if all the discovery endpoints fail, the error will be similar for all.
In the long term we should try and fix this in the downstream dependency
openid-client
>p-any
>p-some
>aggregate-error
References
sindresorhus/aggregate-error#4 (comment)
Testing
issuerBaseURL
at an https server with invalid certsBefore
After
Checklist
master