Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename loading to isLoading #222

Merged
merged 5 commits into from
Jan 5, 2021
Merged

Rename loading to isLoading #222

merged 5 commits into from
Jan 5, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jan 5, 2021 •
edited
Loading

Description

This PR renames loading to isLoading, for consistency with auth0-react.

Also:

  • Renamed .env.template files to .env.local.template. Updated .gitignore to match.
  • Added tsx extension to the pretty package.json script glob.
  • Changed sync for sink in some package.json scripts, as the script build:vercel would exit with an error.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested a review from a team as a code owner January 5, 2021 14:28
@Widcket Widcket changed the title Rename Rename loading to isLoading Jan 5, 2021
@Widcket Widcket added the review:small Small review label Jan 5, 2021
@Widcket Widcket merged commit 72678ea into beta Jan 5, 2021
@Widcket Widcket deleted the fix/loading-rename branch January 5, 2021 14:58
@Widcket Widcket mentioned this pull request Feb 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @adamjmcgrath