Bail out of static rendering for pages and routes in app dir #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1541 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 63 62 -1
Lines 6558 6293 -265
Branches 487 500 +13
==========================================
- Hits 6558 6293 -265
☔ View full report in Codecov by Sentry. |
|
|
6 tasks
|
You must have Developer access to commit code to Auth0 on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/concepts/teams/roles-and-permissions#enterprise-team-account-roles |
adamjmcgrath
temporarily deployed
to
internal
GitHub Actions
Inactive
adamjmcgrath
temporarily deployed
to
internal
GitHub Actions
Inactive
adamjmcgrath
temporarily deployed
to
internal
GitHub Actions
Inactive
|
This works great for my projects - tested on several. Thanks for sorting this, hopefully this can be made official soon? |
adamjmcgrath
temporarily deployed
to
internal
GitHub Actions
Inactive
adamjmcgrath
temporarily deployed
to
internal
GitHub Actions
Inactive
adamjmcgrath
temporarily deployed
to
internal
GitHub Actions
Inactive
ewanharris
reviewed
Nov 13, 2023
src/session/get-access-token.ts
Outdated
| sessionCache: SessionCache | ||
| ): GetAccessToken { | ||
| return async (reqOrOpts?, res?, accessTokenRequest?): Promise<GetAccessTokenResult> => { | ||
| const options = (res ? accessTokenRequest : reqOrOpts) as AccessTokenRequest | undefined; | ||
| const req = (res ? reqOrOpts : undefined) as IncomingMessage | NextApiRequest | undefined; | ||
| // TODO: clean up |
There was a problem hiding this comment.
Should this be removed or is there work to do?
There was a problem hiding this comment.
Ah yep, will remove that comment
ewanharris
reviewed
Nov 13, 2023
adamjmcgrath
temporarily deployed
to
internal
GitHub Actions
Inactive
adamjmcgrath
temporarily deployed
to
internal
GitHub Actions
Inactive
adamjmcgrath
temporarily deployed
to
internal
GitHub Actions
Inactive
ewanharris
approved these changes
Nov 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Ensure
getConfigdoesn't run when the Next.js app is being statically rendered (because static rendering happens at build time and users don't necessarily want to supply the config at build time)The 2 large commits are for making sure the config can be lazily evaluated at request time (
config->getConfig(req)):The 3rd small commit is using this to bail out of static rendering before getting the config.
bec7d6c - Bail out of static rendering for pages and routes in app dir
You can bail out of static rendering by using the
cookies()helper for Server Components and inspecting the request'surlfor API routes📎 References
fixes #1356
vercel/next.js#49006
🎯 Testing