Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing touchSession for exported function #1461

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

benevbright
Copy link
Contributor

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

when touchSession was implemented in #1116 it was missed in exported functions but only added to the instance export.

📎 References

#1458 (comment)

🎯 Testing

@benevbright benevbright requested a review from a team as a code owner September 27, 2023 21:10
@vercel
Copy link

vercel bot commented Sep 27, 2023

@benevbright is attempting to deploy a commit to the Auth0 Team on Vercel.

A member of the Team first needs to authorize it.

@adamjmcgrath
Copy link
Contributor

lgtm - thanks @benevbright

Could you also add the same to https://github.com/auth0/nextjs-auth0/blob/main/src/edge.ts ?

@benevbright
Copy link
Contributor Author

@adamjmcgrath np! done.

Copy link
Contributor

@adamjmcgrath adamjmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benevbright!

@adamjmcgrath adamjmcgrath merged commit d9c8bae into auth0:main Oct 3, 2023
4 of 5 checks passed
@adamjmcgrath adamjmcgrath mentioned this pull request Oct 5, 2023
@benevbright benevbright deleted the fix/missing-touchsession branch October 8, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants