Added support for hCaptcha and Friendly Captcha #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
requested changes
Jul 7, 2023
frederikprijck
requested changes
Jul 13, 2023
| @@ -70,6 +94,11 @@ export class ReCAPTCHA extends React.Component { | |||
|
|
|||
| script.src = scriptUrl; | |||
| script.async = true; | |||
| script.defer = true; | |||
There was a problem hiding this comment.
Same as with auth0.js, is setting defer to true critical to get the functionality work ?
There was a problem hiding this comment.
Same thing, this just supports legacy browsers that would instead load synchronously which is the true risk here. any browser that supports async would use async. Recaptcha, hCaptcha, and Friendly Captcha all specify the use of both to support legacy browsers. But again, happy to conditionally add to hCaptcha and Friendly Captcha if desired.
frederikprijck
previously approved these changes
Jul 13, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| case FRIENDLY_CAPTCHA_PROVIDER: | ||
| return 'friendly-captcha' | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Semicolon insertion Note
frederikprijck
approved these changes
Jul 14, 2023
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added support for hCaptcha and Friendly Captcha as Captcha Providers in our Bot Detection Feature.