Guard references to window on module load #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
force-pushed
the
fix/window-ref
branch
from
5762d20
to
8dadbdc
Compare
lbalmaceda
reviewed
Oct 25, 2021
lbalmaceda
approved these changes
Oct 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Guards some instances of
windowusage at a module level so that builds in SSR environments (like Next.js) no longer fail just by importing the module.References
Fixes #2051
Tested using the provided sample repro here, which now successfully builds with these changes in place: https://github.com/zackdotcomputer/auth0-lock-repro
Testing
Checklist