Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SL - Updated Dutch translations #2013

Merged
merged 2 commits into from
Jul 9, 2021
Merged

SL - Updated Dutch translations #2013

merged 2 commits into from
Jul 9, 2021

Conversation

erombouts
Copy link
Contributor

  • letters to karakters
  • sentence constructions
  • English abbreviations for 'for example' like e.g., i.e., replaced by the Dutch bv.
  • Some cases changed je to u (or uw). Most labels use the more formal u. In English both je and u are 'you'.
  • Other changes

Changes

References

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@erombouts
SL - Updated Dutch translations
315eafd 
- letters to karakters
- sentence constructions
- English abbreviations for 'for example' like e.g., i.e., replaced by the Dutch bv.
- Some cases changed je to u (or uw). Most labels use the more formal u. In English both je and u are 'you'.
- Other changes
@erombouts erombouts requested a review from a team as a code owner July 9, 2021 08:52
frederikprijck
frederikprijck previously approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@frederikprijck frederikprijck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for these changes 🔥 . I added one remark but I don't consider it blocking.

src/i18n/nl.js Outdated Show resolved Hide resolved
@stevehobbsdev stevehobbsdev added this to the vNext milestone Jul 9, 2021
@stevehobbsdev stevehobbsdev added language file Additions or changes to i18n language files review:small Small review CH: Fixed labels Jul 9, 2021
@erombouts @frederikprijck
Update src/i18n/nl.js
0b96524 
Co-authored-by: Frederik Prijck <[email protected]>
@frederikprijck frederikprijck merged commit f89414f into auth0:master Jul 9, 2021
@stevehobbsdev stevehobbsdev mentioned this pull request Jul 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikprijck frederikprijck frederikprijck approved these changes

Assignees
No one assigned
Labels
language file Additions or changes to i18n language files review:small Small review
Projects
None yet
Milestone
v11.30.4
Development

Successfully merging this pull request may close these issues.
3 participants
@erombouts @frederikprijck @stevehobbsdev