Skip to content

Check for null token before splitting #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Check for null token before splitting #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f530b26
Check for null token before splitting
jimmyjames Aug 30, 2022
20fd5b7
Merge branch 'master' into check-for-null-token
jimmyjames Sep 1, 2022
8c14d86
Merge branch 'master' into check-for-null-token
jimmyjames Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/src/main/java/com/auth0/jwt/TokenUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ abstract class TokenUtils {
* @throws JWTDecodeException if the Token doesn't have 3 parts.
*/
static String[] splitToken(String token) throws JWTDecodeException {
if (token == null) {
throw new JWTDecodeException("The token is null.");
}
String[] parts = token.split("\\.");
if (parts.length == 2 && token.endsWith(".")) {
//Tokens with alg='none' have empty String as Signature.
Expand Down
7 changes: 7 additions & 0 deletions lib/src/test/java/com/auth0/jwt/TokenUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,11 @@ public void shouldThrowOnSplitTokenWithLessThan3Parts() {
String token = "two.parts";
TokenUtils.splitToken(token);
}

@Test
public void shouldThrowOnSplitTokenWithNullValue() {
exception.expect(JWTDecodeException.class);
exception.expectMessage("The token is null.");
TokenUtils.splitToken(null);
}
}