SDK-2955 Ensure issuer and audience validation are required #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Nov 29, 2021
| }, | ||
| { | ||
| name: "it throws an error when it fails to deserialize the claims", | ||
| token: "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJodHRwczovL2dvLWp3dC1taWRkbGV3YXJlLmV1LmF1dGgwLmNvbS8iLCJzdWIiOiIxMjM0NTY3ODkwIiwiYXVkIjpbImh0dHBzOi8vZ28tand0LW1pZGRsZXdhcmUtYXBpLyJdfQ.vR2K2tZHDrgsEh9zNWcyk4aljtR6gZK0s2anNGlfwz0", |
There was a problem hiding this comment.
Just a question, why in this particular case the claims fail to be deserialized, when they seem correct (syntax & expected type)?
The error seems to be related to the signature.
There was a problem hiding this comment.
I updated the test name to better reflect why we fail to deserialize the claims.
There was a problem hiding this comment.
Also changed the signature of the validator.New to not use any jose pkg structs.
Widcket
reviewed
Nov 29, 2021
| return nil, errors.New("keyFunc is required but was nil") | ||
| } | ||
| if signatureAlgorithm == "" { | ||
| return nil, errors.New("signature algorithm is required but was empty") |
There was a problem hiding this comment.
Good catch, I added them here b7f9883
Widcket
reviewed
Nov 29, 2021
sergiught
force-pushed
the
patch/SDK-2955-validation
branch
from
0984691 to
b7f9883
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we ensure that issuer and audience validation happen out of the box.
References
Testing
Checklist
master.