Skip to content

Conversation

@grounded042
Copy link
Contributor

This PR adds a cookie token extractor for v2. It borrows heavily from the work done in #10.

It's quite simple - it allows you to specify a cookie name and then will pull the token from there.

@grounded042 grounded042 requested a review from a team as a code owner June 11, 2021 20:59
@grounded042 grounded042 changed the title add cookie token extractor add cookie token extractor for v2 Jun 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2021

Codecov Report

Merging #93 (eb4ca2a) into v2 (665e7da) will decrease coverage by 0.30%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2      #93      +/-   ##
==========================================
- Coverage   90.56%   90.26%   -0.31%     
==========================================
  Files           2        2              
  Lines         106      113       +7     
==========================================
+ Hits           96      102       +6     
- Misses          9       10       +1     
  Partials        1        1              
Impacted Files Coverage Δ
jwtmiddleware.go 92.95% <85.71%> (-0.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665e7da...eb4ca2a. Read the comment docs.

Copy link

@jfatta jfatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@grounded042 grounded042 merged commit edd753b into v2 Jun 25, 2021
@grounded042 grounded042 deleted the v2-from-cookie branch June 25, 2021 20:01
sergiught pushed a commit that referenced this pull request Nov 1, 2021
d10i pushed a commit to Hikely/go-jwt-middleware that referenced this pull request Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants