Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move transient cookies into one cookie [SDK-1908] #168

Merged
merged 3 commits into from
Dec 23, 2020
Merged

Move transient cookies into one cookie [SDK-1908] #168

merged 3 commits into from
Dec 23, 2020

Conversation

davidpatrick
Copy link
Contributor

Currently all transient cookies (state, nonce, max_age and code_verifier) are stored individually. This refactors these values to be stored in a single cookie.

@davidpatrick davidpatrick requested a review from a team as a code owner December 14, 2020 19:44
adamjmcgrath
adamjmcgrath suggested changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@adamjmcgrath adamjmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually looks like you have some failing tests

@adamjmcgrath
Copy link
Contributor

You need to update the callback tests, eg:

auth_verification: JSON.stringify({
  nonce: '__test_nonce__',
  state: '__test_state__',
}),

For https://github.com/auth0/express-openid-connect/blob/master/test/callback.tests.js#L118-L121

@adamjmcgrath adamjmcgrath mentioned this pull request Dec 17, 2020
Closed
@davidpatrick davidpatrick added review:medium Medium review and removed review:small Small review labels Dec 22, 2020
adamjmcgrath
adamjmcgrath previously approved these changes Dec 22, 2020
View reviewed changes
@davidpatrick davidpatrick merged commit 1c78955 into master Dec 23, 2020
@davidpatrick davidpatrick deleted the transientSingleCookie branch December 23, 2020 20:43
@davidpatrick davidpatrick added this to the v2.2.0 milestone Jan 4, 2021
davidpatrick added a commit that referenced this pull request Jan 13, 2021
@davidpatrick
Release 2.2.0
b7ed8fb 
**Added**
- afterCallback Hook [#168](#168) ([davidpatrick](https://github.com/davidpatrick))

**Changed**
- Move transient cookies into single cookie [#171](#171) ([davidpatrick](https://github.com/davidpatrick))
@davidpatrick davidpatrick mentioned this pull request Jan 13, 2021
Merged
davidpatrick added a commit that referenced this pull request Jan 14, 2021
@davidpatrick
Release 2.2.0
71696c1 
**Added**
- afterCallback Hook [#168](#168) ([davidpatrick](https://github.com/davidpatrick))

**Changed**
- Move transient cookies into single cookie [#171](#171) ([davidpatrick](https://github.com/davidpatrick))
davidpatrick added a commit that referenced this pull request Jan 14, 2021
@davidpatrick
Release 2.2.0
f60ea02 
**Added**
- afterCallback Hook [#168](#168) ([davidpatrick](https://github.com/davidpatrick))

**Changed**
- Move transient cookies into single cookie [#171](#171) ([davidpatrick](https://github.com/davidpatrick))
@adamjmcgrath adamjmcgrath mentioned this pull request Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
CH: Changed review:medium Medium review
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@davidpatrick @adamjmcgrath