Skip to content

mgmt: Adds Checkpoint Pagination support for fetching CustomDomains#939

Merged
kailash-b merged 2 commits into
masterfrom
feat/SDK-8309-1
Mar 26, 2026
Merged

mgmt: Adds Checkpoint Pagination support for fetching CustomDomains#939
kailash-b merged 2 commits into
masterfrom
feat/SDK-8309-1

Conversation

@kailash-b
Copy link
Copy Markdown
Contributor

Changes

Adds Checkpoint Pagination support for fetching Custom Domains via the Management API.

Endpoints changed:

  • GET /custom-domains — now supports checkpoint-based pagination via an additional overload

Classes and methods added:

  • CustomDomainsGetAllRequest — new request model supporting optional Query, Fields, IncludeFields, and Sort parameters
  • ICustomDomainsClient.GetAllAsync(CustomDomainsGetAllRequest, CheckpointPaginationInfo?, CancellationToken) — new overload returning ICheckpointPagedList<CustomDomain>
  • CustomDomainsClient.GetAllAsync(CustomDomainsGetAllRequest, CheckpointPaginationInfo?, CancellationToken) — implementation of the above

Model changes:

  • CustomDomain — added IsDefault (bool?) property mapped to the is_default JSON field

Usage example:

var result = await managementClient.CustomDomains.GetAllAsync(
    new CustomDomainsGetAllRequest { Sort = "domain:1" },
    new CheckpointPaginationInfo(from: null, take: 50)
);


### References

### Testing

- [x] This change adds unit test coverage

- [ ] This change adds integration test coverage

- [x] This change has been tested on the latest version of the platform/language or why not

### Checklist

- [x] I have read the [Auth0 general contribution guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md)

- [x] I have read the [Auth0 Code of Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md)

- [x] All existing and new tests complete without errors

@kailash-b kailash-b requested a review from a team as a code owner March 23, 2026 11:43
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.21%. Comparing base (d893e05) to head (b6fdbda).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #939      +/-   ##
==========================================
+ Coverage   80.11%   80.21%   +0.09%     
==========================================
  Files         462      464       +2     
  Lines        6025     6045      +20     
  Branches      291      293       +2     
==========================================
+ Hits         4827     4849      +22     
+ Misses       1105     1104       -1     
+ Partials       93       92       -1     
Flag Coverage Δ
authIntTests 30.68% <5.00%> (-0.09%) ⬇️
mgmtIntTests 60.21% <100.00%> (+0.16%) ⬆️
unittests 18.27% <5.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@tanya732 tanya732 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kailash-b kailash-b merged commit b08643e into master Mar 26, 2026
8 checks passed
@kailash-b kailash-b deleted the feat/SDK-8309-1 branch March 26, 2026 05:13
@kailash-b kailash-b changed the title Adds Checkpoint Pagination support for fetching CustomDomains mgmt: Adds Checkpoint Pagination support for fetching CustomDomains Mar 26, 2026
@kailash-b kailash-b mentioned this pull request Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants