Skip to content

Conversation

@kailash-b
Copy link
Contributor

@kailash-b kailash-b commented May 7, 2025

Changes

  • Changed the type of LogEntry.Scope from string to dynamic
  • Added a new serialiser that can handle the possible values of LogEntry.Scope i.e string OR string[]

References

Testing

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@kailash-b kailash-b requested a review from a team as a code owner May 7, 2025 08:04
@codecov
Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.62%. Comparing base (a8e0f53) to head (80cb86d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../Serialization/StringOrStringArrayJsonConverter.cs 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #811      +/-   ##
==========================================
+ Coverage   74.57%   74.62%   +0.05%     
==========================================
  Files         441      442       +1     
  Lines        5698     5714      +16     
  Branches      347      350       +3     
==========================================
+ Hits         4249     4264      +15     
  Misses       1296     1296              
- Partials      153      154       +1     
Flag Coverage Δ
authIntTests 31.46% <0.00%> (+0.80%) ⬆️
mgmtIntTests 57.36% <23.52%> (-0.11%) ⬇️
unittests 4.26% <88.23%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kailash-b kailash-b force-pushed the feature/SDK-5934 branch from 5261e5d to 80cb86d Compare May 7, 2025 09:59
@kailash-b kailash-b merged commit 6ee51fd into master May 7, 2025
13 checks passed
@kailash-b kailash-b deleted the feature/SDK-5934 branch May 7, 2025 10:07
@kailash-b kailash-b mentioned this pull request May 12, 2025
3 tasks
@kailash-b kailash-b mentioned this pull request May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants