Skip to content

Conversation

@kailash-b
Copy link
Contributor

@kailash-b kailash-b commented Apr 28, 2025

Changes

  • A new property Headers will now be exposed as part of the AccessTokenResponse.
  • This property will contain all the raw headers returned as part of the http response.
  • Extension methods on Headers property will allow users to parse the raw response headers into easily understandable models. (shown in examples.md)
  • Augmented the RateLimitException with more details to distinguish if the rate limiting was due to token quota breach or was due to generic limiting rules set.

References 📚

Testing

  • Added unit and integration test cases for the newly added response header parsing, extension methods, rate-limit exception.

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@kailash-b kailash-b requested a review from a team as a code owner April 28, 2025 04:15
@codecov
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 96.90722% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.00%. Comparing base (42bf3b6) to head (65ffe24).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Auth0.Core/Exceptions/RateLimit.cs 84.61% 0 Missing and 2 partials ⚠️
...nticationApi/HttpClientAuthenticationConnection.cs 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #808      +/-   ##
==========================================
+ Coverage   74.62%   75.00%   +0.38%     
==========================================
  Files         442      444       +2     
  Lines        5714     5805      +91     
  Branches      350      363      +13     
==========================================
+ Hits         4264     4354      +90     
+ Misses       1296     1295       -1     
- Partials      154      156       +2     
Flag Coverage Δ
authIntTests 30.88% <48.45%> (+0.31%) ⬆️
mgmtIntTests 57.03% <38.14%> (-0.34%) ⬇️
unittests 5.96% <97.61%> (+1.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kailash-b kailash-b force-pushed the feature/SDK-5883 branch 2 times, most recently from 3047584 to 410cb15 Compare April 28, 2025 10:41
@kailash-b kailash-b marked this pull request as draft April 28, 2025 11:18
@kailash-b kailash-b marked this pull request as ready for review May 30, 2025 05:34
tanya732
tanya732 previously approved these changes May 30, 2025
@kailash-b kailash-b merged commit c9fb446 into master May 30, 2025
13 checks passed
@kailash-b kailash-b deleted the feature/SDK-5883 branch May 30, 2025 06:41
@kailash-b kailash-b mentioned this pull request May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants