Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-1258] Remove future iat check #329

Merged
merged 1 commit into from
Jan 10, 2020
Merged

[SDK-1258] Remove future iat check #329

merged 1 commit into from
Jan 10, 2020

Conversation

stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Jan 10, 2020 •
edited
Loading

Description

Remove iat claim value check for ID token validation; continue to check for presence.

References

Closes #320
Closes #322

Testing

Tests for iat future check have been removed

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@stevehobbsdev stevehobbsdev added review:tiny CH: Changed PR is changing something labels Jan 10, 2020
@stevehobbsdev stevehobbsdev requested a review from a team January 10, 2020 10:59
@stevehobbsdev stevehobbsdev merged commit 8d810ea into master Jan 10, 2020
@stevehobbsdev stevehobbsdev deleted the fix/iat branch January 10, 2020 16:16
@stevehobbsdev stevehobbsdev added this to the vNext milestone Jan 10, 2020
@stevehobbsdev stevehobbsdev added CH: Removed PR is removing something and removed CH: Changed PR is changing something labels Jan 10, 2020
@justinhelmer
Copy link

Thanks a lot for doing this.

Can you please escalate the priority of publishing a patch release for this fix? We have multiple customers that are unable to log in and use our product.

Much appreciated.

@stevehobbsdev
Copy link
Contributor Author

@justinhelmer This is now out in 1.6.2.

@snyk-bot snyk-bot mentioned this pull request Feb 20, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
CH: Removed PR is removing something
Projects
None yet
Milestone
v1.6.2
Development

Successfully merging this pull request may close these issues.

Logging message is misleading when iat is before browser clock time Issued At Claim Errors
3 participants
@stevehobbsdev @justinhelmer @damieng