Clear transaction data on error #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
approved these changes
Oct 25, 2019
joshcanhelp
added
CH: Changed
luisrudge
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #217 by cleaning up the transaction data when an error occurs. As highlighted in #217, a build up of transaction cookies is occuring because this data is not cleared/reset when an error occurs. Customers have reported that in this scenario (when an error is raised) their apps simply retry the authentication step. Over a short period of time, this can cause problems with cookie data becoming too large and breaking applications. This PR helps with that by cleaning up data on error.
References
#217
Testing
Checklist
master