Skip to content

Conversation

@adamjmcgrath
Copy link
Contributor

Changes

Statically checking attr's is failing for AsyncAuth0 because the attributes are added dynamically.

I've disabled that type-checking rule because - type support for this SDK is only very basic at the moment. But we will improve it in the future if/when we can get structured API data (like OpenAPI 3) from the Auth0 Management API.

References

fixes #514

@adamjmcgrath adamjmcgrath requested a review from a team as a code owner August 21, 2023 09:18
@adamjmcgrath adamjmcgrath temporarily deployed to internal August 21, 2023 09:18 — with GitHub Actions Inactive
@adamjmcgrath adamjmcgrath temporarily deployed to internal August 21, 2023 09:18 — with GitHub Actions Inactive
@adamjmcgrath adamjmcgrath added this pull request to the merge queue Aug 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 21, 2023
@adamjmcgrath adamjmcgrath added this pull request to the merge queue Aug 21, 2023
@adamjmcgrath adamjmcgrath removed this pull request from the merge queue due to a manual request Aug 21, 2023
@adamjmcgrath adamjmcgrath merged commit a5e0828 into master Aug 21, 2023
@adamjmcgrath adamjmcgrath deleted the fix-async-auth0-types branch August 21, 2023 13:05
@adamjmcgrath adamjmcgrath mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type checks started failing on our codebase with v4.4

3 participants