add support for app state argument #485
Draft
+114
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navaronbracke
commented
Nov 19, 2024
| @@ -160,6 +161,32 @@ void main() { | |||
| expect(params.max_age, null); | |||
| }); | |||
|
|
|||
| test('loginWithRedirect supports appState parameter', () async { | |||
There was a problem hiding this comment.
I ran the tests using flutter test --platform=chrome --tags=browser -v but I didn't see my test name in the verbose output? Is there a way to run this test locally?
Edit: Running with flutter test --platform=chrome --name=loginWithRedirect did make it show up (or maybe I missed it)
navaronbracke
commented
Nov 19, 2024
| @@ -21,6 +21,7 @@ dependency_overrides: | |||
|
|
|||
| dev_dependencies: | |||
| build_runner: ^2.1.8 | |||
| collection: ^1.18.0 | |||
There was a problem hiding this comment.
For the MapEquality in the test, hence a dev dependency
|
It seems I still missed a step, as the app state is not passed to the redirect url when actually coming back to the app. Once that is fixed, this is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #486
📋 Changes
This PR adds support for the
appStateparameter tologinWithRedirect()for the web.See https://github.com/auth0/auth0-spa-js/blob/f2e566849efa398ca599daf9ebdfbbd62fcb1894/src/global.ts#L298
There is prior art in auth0/auth0-angular#168
🎯 Testing
Added 1 unit test. This can be tested end-to-end by setting up a login with redirect, that uses the app state argument as parameter, and then validating that the app state is returned when the user is redirected back.