Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for nightly (e5cd65) #6

Merged
merged 1 commit into from
Feb 27, 2015

Conversation

mcoffin
Copy link
Contributor

@mcoffin mcoffin commented Feb 27, 2015

The new variance system causes compilation errors when you have empty traits such as

#[lang = "sized"]
trait Sized {}

This follows the new system, but meant copying a couple more traits over from libcore. It might be worth it to consider just building libcore and linking against it or this kind of thing is going to keep coming up.

The #![no_std] attribute was also put behind a feature gate, so I changed that as well.

Note that the MarkerTrait and PhantomFn snipets are taken straight out of libcore.

@auroranockert
Copy link
Owner

Thank you very much!

auroranockert added a commit that referenced this pull request Feb 27, 2015
@auroranockert auroranockert merged commit dcaaeb9 into auroranockert:master Feb 27, 2015
@mcoffin
Copy link
Contributor Author

mcoffin commented Apr 3, 2015

Well, it looks like they could be killing this method too. Doesn't look like this PR hit in the 1.0.0 beta though.

rust-lang/rust#23938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants