Skip to content

UPSTREAM PR #18906: tests : add test-jinja -py option for cross-checking - #955

Open
loci-dev wants to merge 6 commits into
mainfrom
upstream-PR18906-branch_ngxson-xsn/jinja-test-py
Open

UPSTREAM PR #18906: tests : add test-jinja -py option for cross-checking#955
loci-dev wants to merge 6 commits into
mainfrom
upstream-PR18906-branch_ngxson-xsn/jinja-test-py

Conversation

@loci-dev

Copy link
Copy Markdown

Mirrored from ggml-org/llama.cpp#18906

Small QoL feature for test-jinja: Running test-jinja -py will output the results using the original jinja2 python. This is meant to be used to make sure that the test results are all aligned to the reference jinja2 implementation.

The way it works is by simply spawn python3 as a subprocess. Requires to have jinja2 pre-installed via pip

Some tests are currently failing on this mode, which I'm not 100% sure while. May worth investigating.

Note: I haven't tested this on windows

ngxson and others added 2 commits January 18, 2026 00:10
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
@loci-review

loci-review Bot commented Jan 18, 2026

Copy link
Copy Markdown

Explore the complete analysis inside the Version Insights

@loci-review

loci-review Bot commented Jan 18, 2026

Copy link
Copy Markdown

Explore the complete analysis inside the Version Insights

@loci-dev
loci-dev force-pushed the main branch 18 times, most recently from 330153d to fcc95bf Compare January 21, 2026 17:30
@loci-dev
loci-dev force-pushed the main branch 30 times, most recently from f5548f7 to 6eb0c40 Compare January 28, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants