UPSTREAM PR #18789: server: improve slots scheduling for n_cmpl#928
Open
UPSTREAM PR #18789: server: improve slots scheduling for n_cmpl#928
Conversation
|
Explore the complete analysis inside the Version Insights Based on the analysis, no functions were identified with meaningful performance changes between the base and target versions. The code modifications did not result in measurable performance impact. |
|
Explore the complete analysis inside the Version Insights Based on the analysis, no functions were identified with meaningful performance changes between the base and target versions. The code modifications did not result in measurable performance impact. |
74ffea9 to
839190f
Compare
0da3c3b to
90caac4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#18789
Ref: ggml-org/llama.cpp#18663 (comment)
This PR introduces scheduling mechanism inspired by thread barrier, which allow launching
n_cmplslots at the same time.I tested with repeated requests to
/v1/completionsusing the following payload:{ "prompt": "I believe the meaning of life is", "stream": false, "n": 3, "n_predict": 100, "id_slot": 0 }And so far it works correctly