UPSTREAM PR #18658: model-conversion : add detect_pooling script#843
Open
UPSTREAM PR #18658: model-conversion : add detect_pooling script#843
Conversation
This commit adds a Python script to automatically detect the pooling configuration from a sentence-transformers model directory. The motivation for this change is that I make a mistake when adding the sentence-transformers support and I incorrectly assumed that if an embedding model uses sentence-transformers, it always used pooling. With the recent addition of support for late interaction models, which can have a down-projection but do not use pooling (like LFM2-ColBert-350M). This commit builds upon ggml-org/llama.cpp#18464 which needs to be merged first. Refs: ggml-org/llama.cpp#18607 (comment)
|
Explore the complete analysis inside the Version Insights Perfect! I've retrieved the summary report for your project. Here's what the analysis shows: Summary Report for llama.cpp PR #843Key Findings:
Project Information:
This is a positive result indicating that your code changes don't introduce any performance regressions or unexpected improvements, maintaining consistent performance characteristics across the codebase. Would you like more detailed information about specific functions or any other aspect of this performance comparison? |
7515e5e to
5dbcd6b
Compare
048ad94 to
6c1fde6
Compare
d4c3480 to
f998d1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#18658
This commit adds a Python script to automatically detect the pooling configuration from a sentence-transformers model directory.
The motivation for this change is that I make a mistake when adding the sentence-transformers support and I incorrectly assumed that if an embedding model uses sentence-transformers, it always used pooling. With the recent addition of support for late interaction models, which can have a down-projection but do not use pooling (like LFM2-ColBert-350M).
This commit builds upon ggml-org/llama.cpp#18464 which needs to be merged first.
Refs: ggml-org/llama.cpp#18607 (comment)