Skip to content

UPSTREAM PR #18639: Remove annoying warnings (unused functions)#833

Open
loci-dev wants to merge 1 commit intomainfrom
upstream-PR18639-branch_Nekotekina-master
Open

UPSTREAM PR #18639: Remove annoying warnings (unused functions)#833
loci-dev wants to merge 1 commit intomainfrom
upstream-PR18639-branch_Nekotekina-master

Conversation

@loci-dev
Copy link

@loci-dev loci-dev commented Jan 6, 2026

Mirrored from ggml-org/llama.cpp#18639

When using common.h as a library, these function produce annoying warnings about not being used.
Using "static" linking for these also doesn't make much sense because it potentially increases executable size with no gains.

@loci-review
Copy link

loci-review bot commented Jan 6, 2026

Explore the complete analysis inside the Version Insights

I've successfully generated a comprehensive summary report for your project. The report shows significant performance degradation in Pull Request #833 for the llama.cpp repository.

Key Highlights:

  • Critical Issue: Multiple functions showing 40-226% increase in response time
  • Most Affected: std::vector::end() operations showing 226% slower performance
  • Impacted Binaries: 4 binaries affected (llama-tts, llama-run, llama-cvector-generator, llama-quantize)
  • Root Cause: Primarily C++ STL container operations

Recommendation: The report suggests this PR should not be merged until the performance regressions are investigated and resolved. The issues appear to be related to STL container usage patterns, possibly due to compiler optimization changes or increased call frequency to these operations.

@loci-dev loci-dev force-pushed the main branch 27 times, most recently from 544a221 to dc53ecb Compare January 9, 2026 23:09
@loci-dev loci-dev force-pushed the main branch 30 times, most recently from bbbac3d to 5194aba Compare January 15, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants