UPSTREAM PR #18639: Remove annoying warnings (unused functions)#833
Open
UPSTREAM PR #18639: Remove annoying warnings (unused functions)#833
Conversation
|
Explore the complete analysis inside the Version Insights I've successfully generated a comprehensive summary report for your project. The report shows significant performance degradation in Pull Request #833 for the llama.cpp repository. Key Highlights:
Recommendation: The report suggests this PR should not be merged until the performance regressions are investigated and resolved. The issues appear to be related to STL container usage patterns, possibly due to compiler optimization changes or increased call frequency to these operations. |
544a221 to
dc53ecb
Compare
bbbac3d to
5194aba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#18639
When using common.h as a library, these function produce annoying warnings about not being used.
Using "static" linking for these also doesn't make much sense because it potentially increases executable size with no gains.