UPSTREAM PR #18601: memory : add llama_memory_hybrid_iswa#816
Open
UPSTREAM PR #18601: memory : add llama_memory_hybrid_iswa#816
Conversation
|
Explore the complete analysis inside the Version Insights Perfect! I've successfully retrieved the summary report for your project. The report shows that Pull Request #816 for the llama.cpp repository (owned by auroralabs-loci) demonstrates significant performance improvements, particularly in: Key Highlights:
The comparison between base version |
f85d458 to
67c372e
Compare
048ad94 to
6c1fde6
Compare
2f4d02d to
073bd79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#18601
Upcoming models use hybrid caches with sliding window attention.
Tried modifying the existing
llama_memory_hybridto usellama_kv_cache_iswa, but the change was very intrusive.I don't like the code much, it's essentially a copy-paste done by Claude. But it works! Not very confident with the memory subsystem and open to suggestions and feedback on how to improve it.