Skip to content

UPSTREAM PR #18548: graph : reduce topology branching#790

Open
loci-dev wants to merge 1 commit intomainfrom
upstream-PR18548-branch_ggml-org-gg/graph-avoid-branches
Open

UPSTREAM PR #18548: graph : reduce topology branching#790
loci-dev wants to merge 1 commit intomainfrom
upstream-PR18548-branch_ggml-org-gg/graph-avoid-branches

Conversation

@loci-dev
Copy link

@loci-dev loci-dev commented Jan 2, 2026

Mirrored from ggml-org/llama.cpp#18548

ref #18547

Reduce the amount of graph topology changes when switching between token and embedding inputs:

// before
if (ubatch.token) {
    inpL = ggml_scale(ctx0, inpL, sqrtf(n_embd));
    cb(inpL, "inp_scaled", -1);
}

// after
inpL = ggml_scale(ctx0, inpL, ubatch.token ? sqrtf(n_embd) : 1.0f);
cb(inpL, "inp_scaled", -1);

@loci-review
Copy link

loci-review bot commented Jan 2, 2026

Explore the complete analysis inside the Version Insights

Perfect! I've retrieved the summary report for your project. Here are the key findings:

Summary Report for llama.cpp PR #790

Project Information:

Performance Analysis Results:

No Significant Performance Regressions Detected

The analysis shows that Pull Request #790 maintains performance parity with the base version:

  • Response Time Changes: No modified functions with performance changes > 2%
  • Throughput Time Changes: No modified functions with performance changes > 2%

Conclusion:
This is a positive result indicating that the changes in PR #790 are performance-neutral. The modifications don't negatively impact the performance of the llama.cpp project, suggesting the changes are likely focused on functionality improvements, bug fixes, or refactoring while maintaining the existing performance characteristics.

@loci-dev loci-dev force-pushed the main branch 27 times, most recently from c5b5703 to dc4341b Compare January 6, 2026 17:10
@loci-dev loci-dev force-pushed the main branch 30 times, most recently from 3210e33 to 9ffcb53 Compare January 12, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants