UPSTREAM PR #18413: ggml-cuda: use CMAKE_CUDA_ARCHITECTURES if set when GGML_NATIVE=ON#722
Open
UPSTREAM PR #18413: ggml-cuda: use CMAKE_CUDA_ARCHITECTURES if set when GGML_NATIVE=ON#722
Conversation
|
Explore the complete analysis inside the Version Insights Perfect! I've generated the summary report for your project. Here's what the analysis shows: Summary Report for llama.cpp PR #722Key Findings:
Project Information:
The analysis indicates that the changes in this PR maintain the existing performance profile of the application without introducing any performance regressions. |
bb623bb to
7f36157
Compare
118039a to
cd122e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#18413
Fixed compilation error when building with GGML_NATIVE=ON and CUDA Toolkit but without a GPU (e.g.
docker build) whereCMAKE_CUDA_ARCHITECTURES_NATIVEwill beNo CUDA Devices found., causing nvcc errorUnsupported gpu architecture 'compute_No CUDA Devices found.'.Also if
CMAKE_CUDA_ARCHITECTURESis explicitly set by the user, maybe it's better to use it even whenGGML_NATIVE=ON. Which is also consistent with the behavior before #18361.Additionally moves the logging of
CMAKE_CUDA_ARCHITECTURESafter the replacement.Possibly related to #18398.