UPSTREAM PR #17739: metal : use params per pipeline instance #419
+484
−594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loci-dev
temporarily deployed
to
PROD__AL_DEMO
GitHub Actions
Inactive
loci-dev
force-pushed
the
main
branch
28 times, most recently
from
c217e38 to
a73de67
Compare
loci-dev
force-pushed
the
main
branch
30 times, most recently
from
b29e20d to
0e7b989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#17739
Previously, the pipeline parameters (such as simdgroups, shared mem, etc.) were shared among all pipelines of the same type. Now we can specify them per individual instances.
Fixes a data race + allows more fine-grained control of the parameters in the future.