UPSTREAM PR #16603: llama-cli: add support for reasoning#283
Open
UPSTREAM PR #16603: llama-cli: add support for reasoning#283
Conversation
loci-dev
temporarily deployed
to
PROD__AL_DEMO
GitHub Actions
Inactive
loci-dev
force-pushed
the
main
branch
9 times, most recently
from
462a79d to
dd481ae
Compare
loci-dev
force-pushed
the
main
branch
30 times, most recently
from
48ec5ba to
56f593b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#16603
This change adds a "partial formatter" that processes partially collected messages (like the server streaming logic) in order to render reasoning logic prior to EOG token arrival.
In addition, the chat_add_and_format lambda has been moved to a functor, and this now calls common_chat_templates_apply directly to allow more robust template-application options.
Logic has been put in place to suppress the system/prompt tags to clean up output.
Example output :