Skip to content

Conversation

@DajanaV
Copy link
Collaborator

@DajanaV DajanaV commented Nov 12, 2025

Mirrored from ggml-org/llama.cpp#17214

Previous PR #17091 broke the Dockerfiles because everything was previously linking against the unversioned so files. With the versioning added, links are now against the major version symlink for the so files, and copying only the unversion so files is no longer adequate.

This should fix: ggml-org/llama.cpp#17190, ggml-org/llama.cpp#17176, ggml-org/llama.cpp#17193

This PR preserves those symlinks and includes them in the container.

I have not included a fix for the s390x dockerfile in this PR for two reasons:

  • the s390x Dockerfile is structured differently than the rest of the Dockerfiles and I want to ensure that the changes are fully tested and validated if we're going to modify it. If I can get some guidance on validating that build I'm more than happy to help.
  • I do not want to keep the CI broken for everyone that's not using the s390x Dockerfile while we're fixing that.

For that reason I think it's favorable to open a separate PR for strictly the s390x builds.

@DajanaV DajanaV force-pushed the main branch 11 times, most recently from 24733fb to 4b4bb7c Compare November 13, 2025 12:15
@DajanaV DajanaV closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants