UPSTREAM PR #17134: vulkan: disable rms_norm + mul + rope for old gpus#152
Closed
UPSTREAM PR #17134: vulkan: disable rms_norm + mul + rope for old gpus#152
Conversation
270816b to
87bfdb3
Compare
8a26d77 to
b1d9e01
Compare
24733fb to
4b4bb7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#17134
This disables #16977 for old GPUs with no
float_controls_rte_fp16support as that causes the fused pipelines to not get generated. I didn't look into fixing this properly but for now this'll prevent the app from segfaulting when it hits that fusion op.