UPSTREAM PR #17108: vulkan: fix mmq out of bounds reads #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DajanaV
had a problem deploying
to
PROD__AL_DEMO
GitHub Actions
Failure
DajanaV
had a problem deploying
to
PROD__AL_DEMO
GitHub Actions
Failure
DajanaV
force-pushed
the
main
branch
26 times, most recently
from
87bfdb3 to
a14857a
Compare
DajanaV
force-pushed
the
main
branch
15 times, most recently
from
24733fb to
4b4bb7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#17108
Fixes #17056
I also cleaned up some legacy indexing and buffer size code in the matmul functions.
Draft because I caused a mul_mat_id regression, still trying to find the reason.