UPSTREAM PR #17091: add version to all shared object files#127
Open
UPSTREAM PR #17091: add version to all shared object files#127
Conversation
6aa5dc2 to
81cedf2
Compare
When compiling llama.cpp in Yocto, it fails QA checks because the generated so files aren't versioned. This applies a version to all generated so files, allowing the package to build without errors.
8e5f541 to
2719f80
Compare
|
Access the complete analysis in the LOCI Dashboard Performance Analysis SummaryOverviewPR #127 implements CMake build configuration changes to add version information to shared object files. The analysis reveals a significant discrepancy between the intended scope (build-only changes) and the performance measurement results. Key FindingsPerformance Metrics Impact:
Core Function Analysis:
Inference Performance Impact:
Technical Discrepancy:
Actionable RecommendationsImmediate Investigation Required:
Build Verification:
The complete absence of performance metrics in the target version requires immediate verification to distinguish between legitimate optimization and measurement limitations. |
973f45e to
1a27925
Compare
048ad94 to
6c1fde6
Compare
2f4d02d to
073bd79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#17091
While working on a Yocto recipe for llama.cpp, I got some QA errors because the so files don't have a version set. This is an easy enough fix, you just have to specify one in Cmake.
I've done my best to set these with what I understand are appropriate values, but if I'm pulling in inappropriate variables for any of these, by all means let's fix them. The mtmd stuff in particular seemed a bit ambiguous, but even though it's a "subproject" I imagine the desire (for now) is to still release (and version) it together with llama.cpp as a whole?