UPSTREAM PR #17924: Gigachat 3 tool parser and tests#1135
Open
UPSTREAM PR #17924: Gigachat 3 tool parser and tests#1135
Conversation
These should be tokens, no extra newlines here
|
No summary available at this time. Visit Loci Inspector to review detailed analysis. |
048ad94 to
6c1fde6
Compare
6495042 to
61b4303
Compare
0db6c47 to
8019888
Compare
6fa8e23 to
f2637dc
Compare
5ac00d6 to
998dd7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: ggml-org/llama.cpp#17924
This PR adds a tool parser for parsing the function calls made by the Gigachat 3 models.
Models can generate only one function call using format:
{text}<|message_sep|>\n\nfunction call<|role_sep|>\n{json}Where
<|message_sep|>\n\nand<|role_sep|>\nare special tokens.