Feat(tests): View call profiling#250
Merged
Merged
Conversation
joshuajbouw
approved these changes
Aug 26, 2021
artob
added a commit
that referenced
this pull request
Sep 13, 2021
* ERC-20: change admin address (#184) * Fix promise, broken in upstream (#227) * Feat(tests): View call profiling (#250) * Fix evm_bully feature enabling in Makefile (#252) * Feat(benches): Profile NFT paginated view call (#253) * Update CODEOWNERS (#255) * Bump @openzeppelin/contracts from 4.1.0 to 4.3.1 in /etc/eth-contracts (#254) * Bump tar from 4.4.15 to 4.4.19 in /etc/eth-contracts (#257) * Upgrade nearcore dependencies to latest commit (#259) * 1inch deploy benchmark (#261) Co-authored-by: Dmitry Strokov <dmitry@aurora.dev> Co-authored-by: Joshua J. Bouw <joshua@aurora.dev> Co-authored-by: Kirill <kirill@aurora.dev> Co-authored-by: Michael Birch <michael@aurora.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #199
This PR gives a framework for profiling (measure near gas used) view calls in our tests. It also applies this to profile the one view call we currently do in tests, looking up ERC-20 balances.
In a future PR we can add more sophisticated view workflows, for example NFT pagination which is known to consume lots of gas.