Skip to content

Refactor(tests): Use Signer #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshuajbouw merged 2 commits into from
Jul 30, 2021
Merged

Refactor(tests): Use Signer #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
899fc3f
ERC-20 tests refactor
birchmd Jul 28, 2021
346502b
Sanity test refactor
birchmd Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/test_utils/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,16 @@ impl AuroraRunner {
trie.insert(ft_key, ft_value.try_to_vec().unwrap());
}

pub fn submit_with_signer<F: FnOnce(U256) -> LegacyEthTransaction>(
&mut self,
signer: &mut Signer,
make_tx: F,
) -> Result<SubmitResult, VMError> {
let nonce = signer.use_nonce();
let tx = make_tx(nonce.into());
self.submit_transaction(&signer.secret_key, tx)
}

pub fn submit_transaction(
&mut self,
account: &SecretKey,
Expand Down Expand Up @@ -380,6 +390,17 @@ pub(crate) fn deploy_evm() -> AuroraRunner {
runner
}

pub(crate) fn transfer(to: Address, amount: types::Wei, nonce: U256) -> LegacyEthTransaction {
LegacyEthTransaction {
nonce,
gas_price: Default::default(),
gas: u64::MAX.into(),
to: Some(to),
value: amount,
data: Vec::new(),
}
}

pub(crate) fn create_eth_transaction(
to: Option<Address>,
value: types::Wei,
Expand Down
168 changes: 47 additions & 121 deletions src/tests/erc20.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ use crate::prelude::{Address, U256};
use crate::test_utils::{
self,
erc20::{ERC20Constructor, ERC20},
Signer,
};
use crate::types::Wei;
use bstr::ByteSlice;
Expand All @@ -13,194 +14,130 @@ const TRANSFER_AMOUNT: u64 = 67;

#[test]
fn erc20_mint() {
let (mut runner, source_account, dest_address, contract) = initialize_erc20();
let (mut runner, mut source_account, dest_address, contract) = initialize_erc20();

// Validate pre-state
assert_eq!(
U256::zero(),
get_address_erc20_balance(
&mut runner,
&source_account,
(INITIAL_NONCE + 1).into(),
dest_address,
&contract
)
get_address_erc20_balance(&mut runner, &mut source_account, dest_address, &contract)
);

// Do mint transaction
let mint_amount: u64 = 10;
let mint_tx = contract.mint(dest_address, mint_amount.into(), (INITIAL_NONCE + 2).into());
let outcome = runner.submit_transaction(&source_account, mint_tx);
let outcome = runner.submit_with_signer(&mut source_account, |nonce| {
contract.mint(dest_address, mint_amount.into(), nonce)
});
assert!(outcome.is_ok());

// Validate post-state
assert_eq!(
U256::from(mint_amount),
get_address_erc20_balance(
&mut runner,
&source_account,
(INITIAL_NONCE + 3).into(),
dest_address,
&contract
)
get_address_erc20_balance(&mut runner, &mut source_account, dest_address, &contract)
);
}

#[test]
fn erc20_mint_out_of_gas() {
let (mut runner, source_account, dest_address, contract) = initialize_erc20();
let (mut runner, mut source_account, dest_address, contract) = initialize_erc20();

// Validate pre-state
assert_eq!(
U256::zero(),
get_address_erc20_balance(
&mut runner,
&source_account,
(INITIAL_NONCE + 1).into(),
dest_address,
&contract
)
get_address_erc20_balance(&mut runner, &mut source_account, dest_address, &contract)
);

// Try mint transaction
let mint_amount: u64 = rand::random();
let mut mint_tx = contract.mint(dest_address, mint_amount.into(), (INITIAL_NONCE + 2).into());
let nonce = source_account.use_nonce();
let mut mint_tx = contract.mint(dest_address, mint_amount.into(), nonce.into());

// not enough gas to cover intrinsic cost
mint_tx.gas = (mint_tx.intrinsic_gas(&evm::Config::istanbul()).unwrap() - 1).into();
let outcome = runner.submit_transaction(&source_account, mint_tx.clone());
let outcome = runner.submit_transaction(&source_account.secret_key, mint_tx.clone());
let error = outcome.unwrap_err();
let error_message = format!("{:?}", error);
assert!(error_message.contains("ERR_INTRINSIC_GAS"));

// not enough gas to complete transaction
mint_tx.gas = U256::from(67_000);
let outcome = runner.submit_transaction(&source_account, mint_tx);
let outcome = runner.submit_transaction(&source_account.secret_key, mint_tx);
let error = outcome.unwrap_err();
let error_message = format!("{:?}", error);
assert!(error_message.contains("ERR_OUT_OF_GAS"));

// Validate post-state
test_utils::validate_address_balance_and_nonce(
&runner,
test_utils::address_from_secret_key(&source_account),
test_utils::address_from_secret_key(&source_account.secret_key),
Wei::new_u64(INITIAL_BALANCE),
(INITIAL_NONCE + 3).into(),
);
}

#[test]
fn erc20_transfer_success() {
let (mut runner, source_account, dest_address, contract) = initialize_erc20();
let source_address = test_utils::address_from_secret_key(&source_account);
let (mut runner, mut source_account, dest_address, contract) = initialize_erc20();
let source_address = test_utils::address_from_secret_key(&source_account.secret_key);

let mint_tx = contract.mint(
source_address,
INITIAL_BALANCE.into(),
(INITIAL_NONCE + 1).into(),
);
let outcome = runner.submit_transaction(&source_account, mint_tx);
let outcome = runner.submit_with_signer(&mut source_account, |nonce| {
contract.mint(source_address, INITIAL_BALANCE.into(), nonce)
});
assert!(outcome.is_ok());

// Validate pre-state
assert_eq!(
U256::from(INITIAL_BALANCE),
get_address_erc20_balance(
&mut runner,
&source_account,
(INITIAL_NONCE + 2).into(),
source_address,
&contract
)
get_address_erc20_balance(&mut runner, &mut source_account, source_address, &contract)
);
assert_eq!(
U256::zero(),
get_address_erc20_balance(
&mut runner,
&source_account,
(INITIAL_NONCE + 3).into(),
dest_address,
&contract
)
get_address_erc20_balance(&mut runner, &mut source_account, dest_address, &contract)
);

// Do transfer
let transfer_tx = contract.transfer(
dest_address,
TRANSFER_AMOUNT.into(),
(INITIAL_NONCE + 4).into(),
);
let outcome = runner
.submit_transaction(&source_account, transfer_tx)
.submit_with_signer(&mut source_account, |nonce| {
contract.transfer(dest_address, TRANSFER_AMOUNT.into(), nonce)
})
.unwrap();
assert!(outcome.status);

// Validate post-state
assert_eq!(
U256::from(INITIAL_BALANCE - TRANSFER_AMOUNT),
get_address_erc20_balance(
&mut runner,
&source_account,
(INITIAL_NONCE + 5).into(),
source_address,
&contract
)
get_address_erc20_balance(&mut runner, &mut source_account, source_address, &contract)
);
assert_eq!(
U256::from(TRANSFER_AMOUNT),
get_address_erc20_balance(
&mut runner,
&source_account,
(INITIAL_NONCE + 6).into(),
dest_address,
&contract
)
get_address_erc20_balance(&mut runner, &mut source_account, dest_address, &contract)
);
}

#[test]
fn erc20_transfer_insufficient_balance() {
let (mut runner, source_account, dest_address, contract) = initialize_erc20();
let source_address = test_utils::address_from_secret_key(&source_account);
let (mut runner, mut source_account, dest_address, contract) = initialize_erc20();
let source_address = test_utils::address_from_secret_key(&source_account.secret_key);

let mint_tx = contract.mint(
source_address,
INITIAL_BALANCE.into(),
(INITIAL_NONCE + 1).into(),
);
let outcome = runner.submit_transaction(&source_account, mint_tx);
let outcome = runner.submit_with_signer(&mut source_account, |nonce| {
contract.mint(source_address, INITIAL_BALANCE.into(), nonce)
});
assert!(outcome.is_ok());

// Validate pre-state
assert_eq!(
U256::from(INITIAL_BALANCE),
get_address_erc20_balance(
&mut runner,
&source_account,
(INITIAL_NONCE + 2).into(),
source_address,
&contract
)
get_address_erc20_balance(&mut runner, &mut source_account, source_address, &contract)
);
assert_eq!(
U256::zero(),
get_address_erc20_balance(
&mut runner,
&source_account,
(INITIAL_NONCE + 3).into(),
dest_address,
&contract
)
get_address_erc20_balance(&mut runner, &mut source_account, dest_address, &contract)
);

// Do transfer
let transfer_tx = contract.transfer(
dest_address,
(2 * INITIAL_BALANCE).into(),
(INITIAL_NONCE + 4).into(),
);
let outcome = runner
.submit_transaction(&source_account, transfer_tx)
.submit_with_signer(&mut source_account, |nonce| {
contract.transfer(dest_address, (2 * INITIAL_BALANCE).into(), nonce)
})
.unwrap();
assert!(!outcome.status); // status == false means execution error
let message = parse_erc20_error_message(&outcome.result);
Expand All @@ -209,23 +146,11 @@ fn erc20_transfer_insufficient_balance() {
// Validate post-state
assert_eq!(
U256::from(INITIAL_BALANCE),
get_address_erc20_balance(
&mut runner,
&source_account,
(INITIAL_NONCE + 5).into(),
source_address,
&contract
)
get_address_erc20_balance(&mut runner, &mut source_account, source_address, &contract)
);
assert_eq!(
U256::zero(),
get_address_erc20_balance(
&mut runner,
&source_account,
(INITIAL_NONCE + 6).into(),
dest_address,
&contract
)
get_address_erc20_balance(&mut runner, &mut source_account, dest_address, &contract)
);
}

Expand Down Expand Up @@ -273,13 +198,11 @@ fn deploy_erc_20_out_of_gas() {

fn get_address_erc20_balance(
runner: &mut test_utils::AuroraRunner,
signing_account: &SecretKey,
nonce: U256,
signer: &mut Signer,
address: Address,
contract: &ERC20,
) -> U256 {
let balance_tx = contract.balance_of(address, nonce);
let outcome = runner.submit_transaction(signing_account, balance_tx);
let outcome = runner.submit_with_signer(signer, |nonce| contract.balance_of(address, nonce));
assert!(outcome.is_ok());
U256::from_big_endian(&outcome.unwrap().result)
}
Expand All @@ -291,7 +214,7 @@ fn parse_erc20_error_message(result: &[u8]) -> String {
String::from_utf8(result[start_index..end_index].to_vec()).unwrap()
}

fn initialize_erc20() -> (test_utils::AuroraRunner, SecretKey, Address, ERC20) {
fn initialize_erc20() -> (test_utils::AuroraRunner, Signer, Address, ERC20) {
// set up Aurora runner and accounts
let mut runner = test_utils::deploy_evm();
let mut rng = rand::thread_rng();
Expand All @@ -304,12 +227,15 @@ fn initialize_erc20() -> (test_utils::AuroraRunner, SecretKey, Address, ERC20) {
);
let dest_address = test_utils::address_from_secret_key(&SecretKey::random(&mut rng));

let mut signer = Signer::new(source_account);
signer.nonce = INITIAL_NONCE;
let nonce = signer.use_nonce();
let constructor = ERC20Constructor::load();
let contract = ERC20(runner.deploy_contract(
&source_account,
|c| c.deploy("TestToken", "TEST", INITIAL_NONCE.into()),
&signer.secret_key,
|c| c.deploy("TestToken", "TEST", nonce.into()),
constructor,
));

(runner, source_account, dest_address, contract)
(runner, signer, dest_address, contract)
}
Loading