Extract builder logic to separate classes #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 17, 2017 11:50
|
Quick look, I didn't find any problem. It looks all api and tests are working without changes. So I am 👍 . |
|
Nice
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To separate the concerns of "collecting" query parts, and "building" them into a statement, this PR moves the
build*()methods to their own classes. This entails creating a builder for each kind of statement (select/insert/update/delete) and in some cases a driver-specific builder for the statement (mysql insert and pgsql everything).@pavarnos @harikt etc: any comments or concerns?