Repository navigation
feat(embed): expose package manifest types - #1168
Conversation
Greptile SummaryExposes Aube’s package manifest types through the stable embedding facade.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The exported manifest dependency is unconditional, the exposed types support the tested serialization behavior, and the new test exercises the facade without changing existing runtime behavior. Important Files Changed
Reviews (1): Last reviewed commit: "feat(embed): expose package manifest typ..." | Re-trigger Greptile |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesEmbedded manifest support
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Instruction countsNothing was compared, and so nothing was gated. No series appears on both sides: either the base has no measurements recorded, or the two were measured on different runner classes, which are deliberately not comparable — counts shift between machine types by more than a real regression does. New, nothing to compare against: Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
Summary
PackageJson,Workspaces, and the manifest error type from the stable embedding facadeWhy
Embedding hosts currently have to depend on
aube-manifestdirectly or duplicate package.json schemas. Keeping these types onaube::embedgives hosts a stable route to Aube’s workspace syntax and tolerant dependency parsing.Validation
cargo fmt --checkcargo test -p aube embed::testscargo clippy -p aube --lib -- -D warningsAI-assisted — Tool: Codex; model: openai/gpt-5; version: unavailable.
Note
Low Risk
Public re-exports and a test only; no changes to install, lockfile, or resolution behavior.
Overview
Embedding hosts can use
PackageJson,Workspaces, andManifestErrorfrom the stableaube::embedfacade instead of taking a directaube-manifestdependency or duplicating schemas.A new unit test parses a messy
package.jsonthrough the re-exportedPackageJsontype and asserts workspace patterns, null/empty dependency maps, and invalid dependency entries are handled the same way Aube does elsewhere.Reviewed by Cursor Bugbot for commit 71219dc. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
Bug Fixes
New Features