Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(config): clarify scope of directory filter_mode #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tessus
Copy link
Contributor

@tessus tessus commented Jul 15, 2024

Currently the table leaves the impression that the directory mode is limited to the current host, since from top to bottom is global, host, and session. Session is obviously limited to the host, thus leaves the next filter a bit ambiguous. Is it also limited to the host?

This change clarifies the scope of the filter.

Mode Description
global (default) Search history from all hosts, all sessions, all directories
host Search history just from this host
session Search history just from the current session
directory Search history just from the current directory (global)

P.S.: I've just noticed that my editor also got rid of superfluous whitespace characters.

Currently the table leaves the impression that the directory mode is
limited to the current host, since from top to bottom is global, host,
and session. Session is obviously limited to the host, thus leaves the
next filter a bit ambiguous. Is it also limited to the host?

This change clarifies the scope of the filter.
@tessus
Copy link
Contributor Author

tessus commented Nov 19, 2024

I wanted to bring this up again.

But if you think it is clear that directory is a global search, please feel free to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant