Fix reverse import order for zsh and nu #2370
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #178
Contains the following changes:
Added
DoubleEndedIterator
implementation forUnixByteLines
.Reversed import order for
zsh
I had to make some additional changes to handle commands spanning multiple lines: the previous command is prepended to the current one if it contains a line break (i.e. we need to keep the original import order for commands on multiple lines).
Reversed import order for
nu
Simply reversed the order for
nu
. Commands spanning multiple lines do not need to be handled differently since they are stored in a single line in the history.The import order for
bash
,fish
andreplxx
seem to be correct already.I also did not touch
resh
as I could not test locally since it tries importing".resh_history.json"
whereasresh
seems to be storing its history inhistory.reshjson
. So that appears to be a separate issue unless I missed something.Checks