This repository has been archived by the owner on Feb 4, 2020. It is now read-only.
Replace old cwd option with configPath for mjmlconfig support #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution @jskrzypek! |
|
Hi, any news about merging this? |
|
@thierrymichel The mjmlconfig support will come with the next stable MJML version (4.2.0). (The current MJML version is 4.2.0-beta.2.) I will merge it when MJML 4.2.0 released. |
|
there are some minor additional changes that were made after they accepted
my PR, the main one relevant to this project is that they changed the name
of the option from "configPath" to "mjmlConfigPath"
…On Mon, Sep 24, 2018 at 7:40 PM Attila Buti ***@***.***> wrote:
@thierrymichel <https://github.com/thierrymichel> The mjmlconfig support
will come with the next stable MJML version (4.2.0). (The current MJML
version is 4.2.0-beta.2.) I will merge it when MJML 4.2.0 released.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABcXMb0GWb2EwuRb9WCICaKo9S7SgRzKks5ueQr2gaJpZM4UHEou>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should add/update support for mjmlconfig in v4 once the code is released (I think it should land in 4.1) the mjml PR to track is mjmlio/mjml#1206