Remove NV_PUBLIC #1045
Closed
Remove NV_PUBLIC #1045
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The definition of `NV_PUBLIC` is wrong. It includes two symbols, `NV_NOSCOPE` and `NV_NOADD`, that can never appear in the `nvflag` struct member. So it doesn't make any sense to include them given how `NV_PUBLIC` is used. It is a no-op for two of the three places it is used. For the third use all it does is filter out `NV_NOFREE` from the flag so do that explicitly. Looking at the ksh93u+ branch its use appears to be broken there as well. So the code has been this way for quite a while. Related #1038
I've satisfied myself that this is another symbol that does not need to be aliased to a symbol valid for a `nvflag`. Related #1038
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definition of
NV_PUBLICis wrong. It includes two symbols,NV_NOSCOPEandNV_NOADD, that can never appear in thenvflagstructmember. So it doesn't make any sense to include them given how
NV_PUBLICis used.
It is a no-op for two of the three places it is used. For the third use
all it does is filter out
NV_NOFREEfrom the flag so do that explicitly.Looking at the ksh93u+ branch its use appears to be broken there as
well. So the code has been this way for quite a while.
Related #1038