Use bleeding-edge svd2rust
#197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A pair of changes (rust-embedded/svd#119, rust-embedded/svd2rust#444) recently went into the `svd2rust` and `svd-parser` crates that improves the handling of cluster names and the generation of full type paths for cluster instances. Until these changes are part of a release have `update.sh` pull a fork of `svd2rust` that uses the master version of `svd-parser`. See atsamd-rs#195.
gkelly
force-pushed
the
bleeding-edge-svd2rust
branch
from
e9a405b to
2b84214
Compare
|
Could you maybe pin the commit hash so we don't get other unexpected bleeding edge changes? |
Ensure that changes in the upstream gkelly/svd2rust repository don't end up accidentially included during normal use by pinning to a specific revision.
|
Just pushed a commit that pins |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pair of changes (rust-embedded/svd#119, rust-embedded/svd2rust#444)
recently went into the
svd2rustandsvd-parsercrates. Until thesechanges are part of a release have
update.shpull a fork ofsvd2rustthat uses the master version of
svd-parser.See #195.