allow .atoum.yml file to be absent #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $loader->load('.atoum.yml'); | ||
|
|
||
| try { | ||
| $loader->load('.atoum.yml'); |
There was a problem hiding this comment.
I'd rather do a file_exists here and use the try...catch to catch Yaml parser errors.
There was a problem hiding this comment.
ok. I will ll change that.
but I will also try to remove the filelocator for the .atoum.yml, just to be certain that the check and the loaded file are on the same path (for now the .atoum.yml could also be in the resources folder).
In order to load the extension and still leave the user to choice to load the .atoum.php or the .atoum.yml file, we need to avoid having an exception when the file is not present. So when catch the exception if the file has not been found in the folders.
agallou
force-pushed
the
allow_file_absent
branch
from
f2c9184 to
c54e3d4
Compare
|
@jubianchi PR updated to check if the file is present |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to load the extension and still leave the user to choice to load
the .atoum.php or the .atoum.yml file, we need to avoid having an exception
when the file is not present.
So when catch the exception if the file has not been found in the folders.