Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace collision with flash_offset #30

Open
UncleGrumpy opened this issue Oct 15, 2024 · 3 comments · May be fixed by #35
Open

Namespace collision with flash_offset #30

UncleGrumpy opened this issue Oct 15, 2024 · 3 comments · May be fixed by #35

Comments

@UncleGrumpy
Copy link
Contributor

When I added stm32 support I did not consider the inconvenience reusing the flash_offset setting, also used by esp32, could cause. This could be quite inconvenient for anyone developing an app meant to run on either device family.

I think changing the stm32 platform to use stm_flash_offset would be helpful for users, as they could configure the offset for both platforms independently and just run the respective flash tasks without passing an offset or changing mix.exs.

@UncleGrumpy
Copy link
Contributor Author

Another possibility (I don’t know if mix supports this or how it would be done) would be to have per-task configuration sections like the atomvm_rebar3_plugin uses.

@petermm
Copy link
Contributor

petermm commented Oct 15, 2024

+1 for stm_flash_offset

and we should implement support for esp_flash_offset for explicitness, and start using that instead of a soft deprecated flash_offset (still support it but always document esp_flash_offset to be used..)

@UncleGrumpy
Copy link
Contributor Author

UncleGrumpy commented Oct 15, 2024

I had a similar thought about using a more explicit esp_flash_offset too. Even if per-task configuration is supported, an explicit difference still sounds like a good change.

UncleGrumpy added a commit to UncleGrumpy/ExAtomVM that referenced this issue Nov 20, 2024
Changes the mix.exs `flash_offset` name to include the platform name, to allow
configuring an application for both esp32 and stm32 platforms in the application
mix.exs file. The origional name is retauined for command line over-rides.

closes atomvm#30

Signed-off-by: Winford <[email protected]>
UncleGrumpy added a commit to UncleGrumpy/ExAtomVM that referenced this issue Nov 20, 2024
Changes the mix.exs `flash_offset` option to include the platform name, to allow
configuring an application for both esp32 and stm32 platforms in the mix.exs
file. The original name is retained for command line over-rides.

closes atomvm#30

Signed-off-by: Winford <[email protected]>
@UncleGrumpy UncleGrumpy linked a pull request Nov 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants