ESP32/NVS: return tagged tuples instead of just the result #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fadushin
reviewed
Aug 8, 2023
fadushin
reviewed
Aug 8, 2023
fadushin
requested changes
Aug 8, 2023
Use term_binary_heap_size(size) macro in order to calculate required heap size for binary. Signed-off-by: Davide Bettio <[email protected]>
…esult
New fetch function returns either `{ok, result}` or `error`, instead of
`binary()` or `undefined`.
Signed-off-by: Davide Bettio <[email protected]>
pguyot
reviewed
Aug 9, 2023
Right now there are `fetch` and `get` function, `put` name matches better current naming. Signed-off-by: Davide Bettio <[email protected]>
Let's explicitly mention the namespace, rather having a default one, so applications are encouraged using their own namespace, rather a kitchen sink one. Signed-off-by: Davide Bettio <[email protected]>
Signed-off-by: Davide Bettio <[email protected]>
fadushin
requested changes
Aug 9, 2023
| %%----------------------------------------------------------------------------- | ||
| %% @doc Equivalent to nvs_get_binary(?ATOMVM_NVS_NS, Key). | ||
| %% @deprecated Please do not use this function. |
There was a problem hiding this comment.
Note that we use this function in network.erl line 348, so that module should probably be corrected to not use the function.
There was a problem hiding this comment.
We only deprecated esp:nvs_get_binary/1, esp:nvs_get_binary/2 is still valid.
fadushin
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return either
{ok, result}orerror, instead ofbinary()orundefined.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later