ESP32: add support for init / esp32boot.avm
#657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bettio
force-pushed
the
esp32kernel
branch
2 times, most recently
from
e305246
to
6cd8afc
Compare
bettio
commented
Jul 3, 2023
arpunk
reviewed
Jul 5, 2023
bettio
commented
Jul 8, 2023
UncleGrumpy
reviewed
Jul 8, 2023
bettio
force-pushed
the
esp32kernel
branch
2 times, most recently
from
d6f79f0
to
f07cce5
Compare
bettio
force-pushed
the
esp32kernel
branch
2 times, most recently
from
13ec09f
to
b2f582b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bettio
changed the title
esp32boot.avm
bettio
force-pushed
the
esp32kernel
branch
2 times, most recently
from
7ef680e
to
2b1aadc
Compare
fadushin
requested changes
Jul 22, 2023
There was a problem hiding this comment.
High level comments:
Breaking changes:
- The changes to the return value and looping in the
esp32init:start/0function significantly change the current behavior of AtomVM. Specifically, the VM will never terminate with this change. This needs to be discussed. - The current change breaks images created in CI and even by default on the command line without changes to the image building process and the creation of an AVM file to populate the
boot.avmpartition that include the esp32boot contents and the libatomvm.avm contents.
Devops/style issues:
- This PR should be split into probably 3 PRs and reviewed separately
- Addition of a new Nif (
atomvm_get_start_beam_nif) - Change of the return type of an internal API (
sys_open_avm_from_file) - The thrust of this PR -- the new esp32init module and support for it
- Addition of a new Nif (
- The
esp32initmodule needs to be broken up into a core module that doesn't bring in any of the web server or networking logic. This adds code and atoms that do not need to be loaded in the majority of applications that are not using dev mode. - Debugging code needs to be removed
- Dev mode probably needs to be documented in the Getting Started Guide.
bettio
added a commit
that referenced
this pull request
Jul 23, 2023
…type Make atomvm:add_avm_pack_file/2 return a meaningful error This change is required for #657. These changes are made under both the "Apache 2.0" and the "GNU Lesser General Public License 2.1 or later" license terms (dual license). SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
bettio
added a commit
that referenced
this pull request
Jul 24, 2023
NIFs: add atomvm:get_start_beam/1 This change is required in order to implement #657. These changes are made under both the "Apache 2.0" and the "GNU Lesser General Public License 2.1 or later" license terms (dual license). SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
|
If we don't feel 100% sure about a number of choices we can also defer this as default (and hence the mkimage change), and iterate over this more and more until it is good enough for using it as default. |
fadushin
requested changes
Aug 5, 2023
esp32init purpose is to load the application from an application partition. Signed-off-by: Davide Bettio <[email protected]>
Try to boot boot.avm partition first, which will take care of application loading. Signed-off-by: Davide Bettio <[email protected]>
Use atomvm:get_start_beam/1 for finding startup module instead of relying on some static default. Signed-off-by: Davide Bettio <[email protected]>
Do not enable it by default. Signed-off-by: Davide Bettio <[email protected]>
Add (opt-in) NVS setting for enabling always ALISP console and web server. Signed-off-by: Davide Bettio <[email protected]>
Keep esp32init as small as possible. Signed-off-by: Davide Bettio <[email protected]>
bettio
force-pushed
the
esp32kernel
branch
2 times, most recently
from
d1bab7b
to
98b88d4
Compare
fadushin
reviewed
Aug 6, 2023
fadushin
requested changes
Aug 6, 2023
Application is started inside of `try .. catch` block and `timer:sleep(infinity)` is used after application exit according to devmode settings. Signed-off-by: Davide Bettio <[email protected]>
fadushin
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Init takes care of launching startup module and eventually ALISP console and web server according to configuration / in case of failure.
Closes #654
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later